[aur-dev] [PATCH 1/3] Hide the table sorting links on the dashboard

[Mark Weiman]

On Sat, 2017-02-04 at 11:21 +0100, Lukas Fleischer wrote:
> The tables on the dashboard always show the 50 most recent packages,
> ordered by last update. Do not make the table headers of these tables
> clickable.
> 
> Signed-off-by: Lukas Fleischer <lfleischer at archlinux.org>
> ---
>  web/template/pkg_search_results.php | 29 +++++++++++++++++++++--------
>  1 file changed, 21 insertions(+), 8 deletions(-)
> 
> diff --git a/web/template/pkg_search_results.php b/web/template/pkg_search_results.php
> index d596ec2..8a2e8d3 100644
> --- a/web/template/pkg_search_results.php
> +++ b/web/template/pkg_search_results.php
> @@ -1,4 +1,17 @@
>  <?php
> +function fmtth($title, $sb=false, $so=false, $hint=false) {
> +	echo '<th>';
> +	if ($sb) {
> +		echo '<a href="' . mkurl('SB=' . $sb . '&SO = ' . $so) . '">' . $title . '</a>';

There's an issue here where when a URL is generated, the '?' is missing from the
URL causing a URL like ".../packages/SB=..." where that URL will 404. A '?'
needs to be put in between the " and the ' immediately after "href=".

> [...]