[aur-dev] [PATCH 1/3] Hide the table sorting links on the dashboard

Lukas Fleischer lfleischer at archlinux.org
Wed Feb 8 18:19:38 UTC 2017


On Wed, 08 Feb 2017 at 18:34:16, Mark Weiman wrote:
> [...]
> > diff --git a/web/template/pkg_search_results.php b/web/template/pkg_search_results.php
> > index d596ec2..8a2e8d3 100644
> > --- a/web/template/pkg_search_results.php
> > +++ b/web/template/pkg_search_results.php
> > @@ -1,4 +1,17 @@
> >  <?php
> > +function fmtth($title, $sb=false, $so=false, $hint=false) {
> > +     echo '<th>';
> > +     if ($sb) {
> > +             echo '<a href="' . mkurl('SB=' . $sb . '&SO = ' . $so) . '">' . $title . '</a>';
> 
> There's an issue here where when a URL is generated, the '?' is missing from the
> URL causing a URL like ".../packages/SB=..." where that URL will 404. A '?'
> needs to be put in between the " and the ' immediately after "href=".

Good catch, thanks for letting me know. Fixed in pu!

> 
> > [...]


More information about the aur-dev mailing list