[aur-general] TU Application - Ike Devolder

Xyne xyne at archlinux.ca
Sat Mar 3 10:41:24 EST 2012


Ike Devolder wrote:

/snip

> [1] http://aur.archlinux.org/packages.php?SeB=m&L=2&K=BlackIkeEagle

Hi Ike,

I too think that your PKGBUILDs look good. They're clean and well-structured.
The only issue I see is the lack of variable quoting, e.g. I've seen this is
many of them:

make DESTDIR=${pkgdir} install

That will not work if there is a space on the pkgdir path. For example:

$ mkdir 'foo bar'
$ foo='foo bar'
$ cd ${foo}
bash: cd: foo: No such file or directory



Everything else look good. Good luck!

Regards,
Xyne


More information about the aur-general mailing list