[aur-general] Review request for first AUR package

nyuszika7h nyuszika7h+archlinux at cadoth.net
Sun Dec 1 15:02:10 EST 2013


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

On Sun, Dec 01, 2013 at 02:43:13PM -0500, Jeremy Audet wrote:
> > Please review it in case I've missed something.
> 
> You can drop the `pkgdir= #TODO` line completely. makepkg defines $pkgdir
> for you. [1]
> 
> namcap emits several warnings. Run `namcap sic-1.2-1-x86_64.pkg.tar.xz` to
> see them.
> 
> [1] https://www.archlinux.org/pacman/PKGBUILD.5.html#_build_function.
> 
> --Jeremy

It looks like I overlooked that, I accidentally left it in the PKGBUILD.
I didn't even notice it was there, even though vim highlights "TODO".

I'll check the namcap warnings soon.

- --
nyuszika7h
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)
Comment: Homepage: http://nyuszika7h.cadoth.net/
Comment: Public key: http://bit.ly/1aXbBEh

iQIcBAEBCgAGBQJSm5XCAAoJEMrMWwlOwAIGjN4P/R/2MX1/mj8d/xJey656H4fV
3A3eEYeypUvgSJTcBajVlW4Z1ao/0xvGZ28okmUx0d3HoD1FNvsiJEnZh8ZwSU3/
Xw7/EBxRPJyXC8rqSdLNkGSox+ey0+ONAfXfJt/quKe5H/0zFnfXInOkdUmick0y
fOw3ux7C9fRhioSZQGIOUtV1j3pfsMYEqi9hPeYYPP0hhvXtUOeI0HTh892HWDZ+
c/1bfruRrRYCO6/ljJZBQ1ucxrsR6LGPRYOmK2MUXtiwixo+7L0wexSEggfn7Mt7
/OuCSZHF+mWiFhkzDDxgPNMDrvt5paNRMdoMI/GttSSK0O7YAIsPOzRS5g8TAe7g
4g3V6nyiTLw4iICixBz6sYX2qUweoLrKeJj8ds3GYfzkUJL2vYHOtE7HJLg86IPT
V5FM0MPGDex8utQB9B5qv8eejM4vQWFSrM/WOYWH2Zgv0NHYbKRR/AVvjX1aj7/m
owUxdh9JhIRsGUUR9E4NDOKb/FzryeYvrw0VRnCawG4MhYo7NKt1uCt7iPKokdEv
zma++ZfT3YHr1MWFmOPSDGA4IuVDYd56lDr9w5WxZE0qIuqYw5mEPqcDmbn+AilW
/7b/Kxh4OyFqK4RxumYgI6e6Jb8pPKQkeW5hwxkdp0O0fbiU22oBcG++1QRnTgTm
eLcLCjKCDnCzc+TKQzm3
=qZyD
-----END PGP SIGNATURE-----


More information about the aur-general mailing list