[aur-general] Review request for first AUR package

nyuszika7h nyuszika7h+archlinux at cadoth.net
Sun Dec 1 15:11:51 EST 2013


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

On Sun, Dec 01, 2013 at 02:43:13PM -0500, Jeremy Audet wrote:
> > Please review it in case I've missed something.
> 
> You can drop the `pkgdir= #TODO` line completely. makepkg defines $pkgdir
> for you. [1]
> 
> namcap emits several warnings. Run `namcap sic-1.2-1-x86_64.pkg.tar.xz` to
> see them.
> 
> [1] https://www.archlinux.org/pacman/PKGBUILD.5.html#_build_function.
> 
> --Jeremy

Oh, of course, I got confused and forgot DESTDIR and PREFIX are two
separate things.

I've removed the pkgdir line, fixed the namcap warnings, and reuploaded
the package now. Thanks for your help, is there anything else?

- --
nyuszika7h
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)
Comment: Homepage: http://nyuszika7h.cadoth.net/
Comment: Public key: http://bit.ly/1aXbBEh

iQIcBAEBCgAGBQJSm5gHAAoJEMrMWwlOwAIGa34QAKaYVNS4HDI0VNhL18x+M9LP
Yh2TVxTwgyloacmWzx05YWAdL3Waf0SRgjKz4ULeaVVDWgpd8+v27hQ4Rn9dC/sI
FOyBE9qNRZi9SKXTrr8g+nf1JgK/3rEC+dp4fzLrNWZI/4oGhva9TUjAN+aZMEOH
KGA/tetmy+6UkWtfnBJ+mW2PujS6QJSJHLHOOokLUul0PTADDIeiypsO7gYPmuAh
/3Mkmon0LMc0G1cLIHOx5UnPfoVC6A8GcngBNXIn0hmbBZtcYCWBMFqhJHndg9rY
04RwglPKFSJg5nhcnXJdGN1aiG91TfhAhj6wE4pd83AuQVcfFQNOVZj5/BU3XCi0
xx6iy4ApCUSMklEVYbptqx3HexUhYuvCBsMT/143P9fm/ev2F0E11ahID8F42htP
DCio1f/hb5r3vhv+K4wvfzmtM1TYbfS3J5PLOwV3GUv9IrJRteOCENhbeUeFUPoA
cAXIsTDKXS3MUBRLTpby40NGxVDRa2WGpqlj5SNJGjN6Yn9aowrLZBJVEVILiLez
z7q3lDf11ONoFB32H1vmJMdv/3QlwFsgd5Lm510ef4USLoDpT7vYIqGBFy84eiWl
DC1fMXW1KhSaZoFe9nicBCvp6l1f+eupU5H8GNRCX6hhF++i0WGmLQX6pvZTFE5t
oufL2Io+QF/PORjIcNYp
=XjNU
-----END PGP SIGNATURE-----


More information about the aur-general mailing list