[aur-general] TU application - Sponsored by Balló György
martin+arch at flexion.org
Wed Dec 11 12:59:19 EST 2013
Every package I maintain has been updated today taking into to account
the feedback that has been provided in this discussion and the feedback
Balló has sent to me directly.
On Tue, 2013-12-10 at 23:18 +0000, Martin Wimpress wrote:
> > Your PKGBUILDs look good overall but I noticed two things. The first is the
> > absence of quoted variables (e.g $srcdir), but you mentioned that you wrote a
> > script to generate PKGBUILDs so perhaps that is a single, central fault?
> Balló has pointed that out too and it will be resolved in the next few
I've added variable quoting, where appropriate, to all my packages in
the AUR including the MATE packages.
> > The second is the absence of "prepare" functions. There are numerous packages
> > that modify existing source files in the "build" and/or "package" functions
> > (e.g. several replace "python" with "python2"). All such modifications should
> > be done in a separate "prepare" function when possible.
> Also recently pointed out and I have actually started the transition,
> see the mate-file-archiver PKGBUILD below.
prepare() functions have been added, where appropriate, to all my
packages in the AUR including the MATE packages.
> > Beyond that there were just a few niggles. For example, I wonder why you
> > check if the CARCH variable is empty in the brother-mfc7360n-lpr package .
> > The "arch" array restricts available architectures to x86_64 and i686, so the
> > warning doesn't make sense to me.
The `brother-mfc7360n-*` packages have been cleaned up.
> > There are also some apparently inherited PKGBUILD issues, e.g. the missing
> > package function in nullmailer  but I presume those will be fixed whenever
> > the next update happens.
The `nullmailer` package has been updated accordingly.
Thank you all for your input.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 198 bytes
Desc: This is a digitally signed message part
More information about the aur-general