[aur-general] Dell 2155cdn driver PKGBUILD quality check

LoneVVolf lonewolf at xs4all.nl
Sat Dec 26 10:53:08 UTC 2015

On 26-12-15 05:56, Doug Newgard wrote:
> On Sat, 26 Dec 2015 01:13:39 +0100
> Peter Tobler <peter at tobler.cc> wrote:
>> Here is the mentioned PKGBUILD:
>> http://pastie.org/pastes/10652982/text?key=23xhgip17gp9tvriuiyma
> There's no reason to use the conditionals with the depends array anymore,
> pacman supports architecture specific arrays now (depends_i686, etc).
> bsdtar will extract rpm files, no reason to pull in rpmextract.
> Make sure you quote any paths that include any variables that you don't
> control, like ${pkgdir} and ${srcdir}.


since your package uses binaries, please append -bin to it's name.
rpm-based distros use some folders other then arch does, verify if you 
need to move things.

I assume the source-file has separate 32& 64-bit rpms?
If so, you'll have to differentiate between those in package() function.


More information about the aur-general mailing list