[aur-general] PKGBUILD Critique

[Daniel Wallace]

When you do grep like that, you should use two [[, to make sure that it
doesn't care about spaces.

http://stackoverflow.com/questions/669452/is-preferable-over-in-bash-scripts

and in this case, you don't need them at all

	if grep -qi 'utf-*8' /etc/locale.conf; then


The above will fail and not execute the 'then' portion of the if statement
if the grep fails, the -q also prevents it from out putting anything, and
it will return an exit status of not one.

Even with that, the current PKGBUILD looks fine... just wanted to point it
out.

Daniel



On Tue, Feb 10, 2015 at 7:02 PM, stef204 <stef204 at yandex.com> wrote:

> 10.02.2015, 17:20, "David Phillips" <dbphillipsnz at gmail.com>:
> >  . There are
> >  a few points that need clearing up before your PKGBUILD can be
> >  released for use.
> >
> >  I'm probably really crap at explaining this, but it was worth a shot.
>
> Dave,
>
> Thanks for feedback. It's helpful.
>
> You're right about just using ./configure --prefix=/user (only that).
>
> I took a existing build and tried to update it to new standard, which uses
> package () , etc.
>
> And modified very little, really, above package().  I did see the oddity
> in the ./configure option but got so involved in the error I was getting
> from package () that I forgot to backtrack,
>
> Anyway, here is an updated version.
>
> <https://bpaste.net/show/8fdb2226c3d7>
>
> Better?
>
> Thanks.
>