[aur-general] Need help with some patching for my package (gcc44-multilib)

[Giovanni Santini]

In fact, I had to add that stupid patch because, for some reasons, check with GCC version failed; actually, the two checks in that patch (GCC_VERSION >= and <=) should exclude each other... But I had compilation problems, as 'exact_log2' and another function were included both from 'toplevel.c' and 'toplevel.h'.

Giovanni Santini
My blog: http://giovannisantini.tk
My code: https://github.com/ItachiSan

Il 21/giu/2015 12:49 AM, Christian Wieden <wiedenchr at gmail.com> ha scritto:
>
> Until now i haven't finde the Problem but your Patch is confusing because 
> you check the same thing two time's if i see it correctly: 
>
> Your check is: 
> #if __GNUC__ >= 5 || GCC_VERSION >= 3004 
>
> With GCC_VERSION defined as: 
> #define GCC_VERSION (__GNUC__ * 1000 + __GNUC_MINOR__) 
>
> So you are checking if the major Version is greater than or equal GCC 5.x 
> OR if the version is 
> greater than or equal GCC 3.4 
>
> And i didn't see the sense in this expanded #if, or i overlook something. 
>
> Greetings 
>
> 2015-06-20 12:11 GMT+02:00 Giovanni Santini <giovannisantini93 at yahoo.it>: 
>
> > Hello everybody, 
> > I already wrote some days ago a message in this mailing list asking for 
> > help, but I noticed that email clients acted in weird ways (GMail on my 
> > Nexus and Thunderbird on my laptop acted in different ways for the same 
> > mail) so I'm writing you again. 
> > 
> > I started to upload my packages to AUR4 and I tried to build them up in 
> > order to upload working packages... 
> > After GCC 5.X, I am not able to build anymore my package 'gcc44-multilib'. 
> > I had some problems in compiling (toplevel.c), that I fixed an hand-made 
> > patch, but then I have problems in linking (double defines for the function 
> > I fixed with my patch)... 
> > 
> > If someone could give me an hand fixing the package out, it would be 
> > really great. 
> > AUR link: https://aur.archlinux.org/packages/gcc44-multilib/ 
> > AUR4 link: https://aur4.archlinux.org/packages/gcc44-multilib/ 
> > The edited PKGBUILD (including the new patch I made): 
> > https://dl.dropboxusercontent.com/u/4152736/gcc44-multilib_future.tar.gz 
> > The patch I wrote: 
> > https://dl.dropboxusercontent.com/u/4152736/gcc-fix_toplevel_defines.patch 
> > 
> > If someone wants to help me, I can upload my source tarball (3rd link) to 
> > AUR4 so it can be fixed with Git. 
> > 
> > Thank you for your attention. 
> > 
> > -- 
> > Giovanni Santini 
> > My blog: http://giovannisantini.tk 
> > My code: https://github.com/ItachiSan 
> >