[aur-general] RFC: PKGBUILD for tensorflow-git

[Eli Schwartz]

On 11/10/2015 12:59 PM, Pieter ROBYNS wrote:
> Hi Eli,
> 
> Thanks for your feedback! My responses can be found below.

You're welcome.

> Yes you are right, it seems the bazel versions do match but for some reason
> the one from AUR didn't work for me. Could be easily solved with a
> makedepends entry for bazel.
> 
> So, best not to upload to AUR? I'm okay with that, I learned something when
> making the PKGBUILD and now I have a clean bleeding edge package :).

I didn't say that...
Upload it to the AUR whenever you feel confident you have done the best
job you can with the PKGBUILD.
Make use of feedback to improve it where possible.
If it needs to use a custom build of bazel, then do that. If you can
safely use the pre-existing AUR package, then someone's already done the
work for you, which is always better!

I don't see why the AUR package for bazel wouldn't work...
... maybe you caught it while the AUR package was bumped to 0.1.1 -- it
was reverted a couple hours later.
It's the same source code and the same build otherwise.

Gremlins?

> I've found an option in bazel to limit the amount of parallel jobs; perhaps
> that's fine as well.

For Makefiles, there is a default MAKEFLAGS="-j2" in makepkg.conf, which
helps people customize things.
I guess you can just pick a sane default. :thumbsup:

> Hehe, I just followed Google's build instructions and I thought it wouldn't
> matter since their script creates temporary files in /tmp/ anyway. I agree
> that doing it in the build directory of the package is cleaner.
> 
> Thanks again for your advice!
> 
> 
> Kind regards,
> Pieter
> 

Hmm. I wonder why *they* scatter files around /tmp. One extra thing for
them to clean up manually...

-- 
Eli Schwartz