[aur-general] PKGBUILD review
xantares09 at hotmail.com
Fri Feb 5 09:04:20 UTC 2016
mingw-w64-gcc is the only mingw-w64 package you want to makedepend on, maybe consider to depend on mingw-w64-crt.
> From: justin at dray.be
> Date: Fri, 5 Feb 2016 06:30:32 +0000
> To: aur-general at archlinux.org
> Subject: Re: [aur-general] PKGBUILD review
> You've still got references to OS X and windows installs
> Also instead of
> if test _arch == '32'; then
> scons -j $cores platform=server target=release_debug tools=no bits=32
> scons -j $cores platform=server target=release_debug tools=no bits=64
> you can just do
> scons -j $cores platform=server target=release_debug tools=no bits=$_arch
> You're setting _arch in 3 places even though it can only have 2 values;
> it's also in an array for no apparent reason, you can shorten it to
> [[ $CARCH == x86_64 ]] && _arch=64
> Or some such variation.
> The same goes in the install, you have a bunch of 'if _arch == 32' and then
> using 32 twice in a string; just substitute that with the variable.
More information about the aur-general