[aur-general] PKGBUILD review request: understand-bin

[Doug Newgard]

On Mon, 13 Jun 2016 14:14:00 +0300
Alex Sarum via aur-general <aur-general at archlinux.org> wrote:

> Hello,
> 
> This is my first PKGBUILD. If someone has time, I would like to get some reviews
> from other archers.
> 
> https://gitlab.com/saruman9/pkgbuilds/tree/master/understand-bin
> 
> --
> Alex

What's with the "scitools" variable? Doesn't seem to do anything useful.

source and checksum arrays support architecture specific arrays now. Check the
man page/wiki page.

You shouldn't be changing anything in $srcdir in the package function. What
happens when someone runs makepkg --repackage?

There's really no reason to change the name of the license file.

"install -d "$pkgdir/usr/bin"" doesn't really do anything since you're using
the -D option on the next line. That will create the dir.

You should be consistent with how you use variables. Sometimes you have them in
braces and sometimes you don't, even in the same path.