[aur-general] PKGBUILD review request: understand-bin
rum.274.4 at gmail.com
Tue Jun 14 12:31:46 UTC 2016
> What's with the "scitools" variable? Doesn't seem to do anything useful.
> source and checksum arrays support architecture specific arrays now. Check the
> man page/wiki page.
I known about it, but I think that it will be shorter.
> You shouldn't be changing anything in $srcdir in the package function. What
> happens when someone runs makepkg --repackage?
> There's really no reason to change the name of the license file.
> "install -d "$pkgdir/usr/bin"" doesn't really do anything since you're using
> the -D option on the next line. That will create the dir.
> You should be consistent with how you use variables. Sometimes you have them in
> braces and sometimes you don't, even in the same path.
I can share my PKGBUILD now?
I have not received a reply. I waited digest and copied ID message to
In-Reply-To. I hope this will works. So it should be?
And sorry for my EnGlIsH.
More information about the aur-general