[aur-general] PKGBUILDs for monkeysphere feedback
baptiste at bitsofnetworks.org
Wed Jun 22 10:12:00 UTC 2016
On Wed, Jun 22, 2016 at 11:30:57AM +0200, Valo wrote:
> As gnupg 2.1.13 is now available in core I'd like to update monkeysphere
> to 0.38, here are the PKGBUILDs for monkeysphere and for
> agent-transfer, a new monkeysphere checkdependency.
> Agent-transfer is included in the monkeysphere source code but it's a
> checkdependency and so I choose to create a separate package for it, is
> it correct? How can I make it better?
Do you think that agent-transfer is a useful package in its own right?
That is, can it be used and be useful without monkeysphere? If so, it
could make sense to provide it as a separate package, but I think you
should implement it as a split package then (since both monkeysphere and
agent-transfer "build" from the same source).
Of course, to avoid over-engineering, you could just have a single package
bundling both monkeysphere and agent-transfer. Judging from , this is
what is intended by upstream.
Also, some minor nitpicks:
- you have a small typo in agent-transfer ("makedepens")
- the "gcc" makedepends is not needed, because it is in base-devel 
- as you have apparently figured out, installing in /usr/sbin/ is not
recommended , but I don't think it's worth patching the source .
/usr/sbin is a symbolic link to /usr/bin anyway.
- I'm not sure about the convention for adding users/groups . Looking
at a few packages [6,7,8], it seems that UID and GID are hard-coded, but I
don't know if there is a registry. At the very least, you should create
a system user (-r option to useradd), because otherwise the UID will
fall into the user range 1000+.
Thanks for maintaining the package!
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 819 bytes
Desc: not available
More information about the aur-general