[aur-general] Trusted User Application: Giancarlo Razzolini

[Levente Polyak]

Hi Giancarlo,

thanks for your application and jelle for sponsoring.

As always I want to give my 2 cents to your PKGBUILDs so you could
improve certain points before the voting period starts.
Please don't be scared! :)

cheers,
Levente

PS: some of the blocks are copy-paste, its just lot easier this way :]


chkboot:
========
- the non VCS packages should not have provides,conflicts,replaces to
  any packages that provide the "main" one (like chkboot-git), it
  should always be the other way around.

- the .install file used in the install= variable does not need to be in
  the sources array.

- all download targets in the source array must be unique as they could
  overlap if using the same download directory. f.e. are cases like
  github where the tarball only has version number. those should be
  renamed by adding pkgname, f.e.: ${pkgname}-${pkgver}.tar.gz::https...

esekeyd:
========
- the .install file used in the install= variable does not need to be in
  the sources array.

- any use of $pkgdir and $srcdir must be put into double-quotes as they
  may contain spaces. (package() function)

- simple documentation like mentioning to edit config file and use
  systemctl should not be put into .install files, thats not their
  purpose

keepass-plugin-keeagent:
========================
- the .install file used in the install= variable does not need to be in
  the sources array.

- the "main" packages should not have provides,conflicts,replaces to
  any packages that provide the "main" one (like keepass-plugin-
  keeagent-beta), it  should always be the other way around.

- any use of $pkgdir must be put into double-quotes as they may contain
  spaces. (package() function)

keepass-plugin-keeagent-beta:
=============================
- the .install file used in the install= variable does not need to be in
  the sources array.

- any use of $pkgdir must be put into double-quotes as they may contain
  spaces. (package() function)

memlockd:
=========
- the .install file used in the install= variable does not need to be in
  the sources array.

- any use of $pkgdir and $srcdir must be put into double-quotes as they
  may contain spaces. (package() function)

- never delete user accounts with userdel in the .install files as they
  may possibly still own files. there is no point doing so (for further
  information you can search the arch-dev-public ML)

mkinitcpio-chkcryptoboot:
=========================
- the .install file used in the install= variable does not need to be in
  the sources array.

- _huge_ chunk of documentation in the .install file. that really
   shouldn't be the place and purpose of such. A wiki entry and/or
   a text file in the /usr/share/doc/${pkgname} is a better place.

mkinitcpio-ddns:
================
- most likely one of the longest description I have ever encountered.
  Matter of taste but i find that slightly too long :P

- the .install file used in the install= variable does not need to be in
  the sources array.

- _huge_ chunk of documentation in the .install file. that really
   shouldn't be the place and purpose of such. A wiki entry and/or
   a text file in the /usr/share/doc/${pkgname} is a better place.

mkinitcpio-dropbear:
====================
- documentation should normally not be in the .install file but a wiki
  entry and/or a text file in the /usr/share/doc/${pkgname} is a better
  place.

mkinitcpio-netconf:
===================
- any use of $pkgdir and $srcdir must be put into double-quotes as they
  may contain spaces. (package() function)

- _huge_ chunk of documentation in the .install file. that really
   shouldn't be the place and purpose of such. A wiki entry and/or
   a text file in the /usr/share/doc/${pkgname} is a better place.

mkinitcpio-ppp:
===============
- the .install file used in the install= variable does not need to be in
  the sources array.

- _huge_ chunk of documentation in the .install file. that really
   shouldn't be the place and purpose of such. A wiki entry and/or
   a text file in the /usr/share/doc/${pkgname} is a better place.

mkinitcpio-tinyssh:
===================
- _huge_ chunk of documentation in the .install file. that really
   shouldn't be the place and purpose of such. A wiki entry and/or
   a text file in the /usr/share/doc/${pkgname} is a better place.

mkinitcpio-utils:
=================
- documentation should normally not be in the .install file but a wiki
  entry and/or a text file in the /usr/share/doc/${pkgname} is a better
  place.

tinyssh-convert:
================
- any use of $pkgdir must be put into double-quotes as they
  may contain spaces. (package() function)

- the non VCS packages should not have provides,conflicts,replaces to
  any packages that provide the "main" one (like ${pkgname}-git), it
  should always be the other way around.

tinyssh-convert-git:
====================
- any use of $pkgdir must be put into double-quotes as they
  may contain spaces. (package() function)

ucspi-tcp:
==========
- any use of $srcdir must be put into double-quotes as they
  may contain spaces. (package() function)

- no need for any  || return 1

- patching should be done in prepare()

- make should be done in build()

- 'gcc' 'make' 'patch' all belong to base-devel and is not needed as
   makedepends

wine-ivb:
=========
- any use of $pkgdir must be put into double-quotes as they
  may contain spaces. (prepare() function)

wine-staging-ivb:
=================
- all download targets in the source array must be unique as they could
  overlap if using the same download directory. f.e. the
  staging-$_pkgbasever.tar.gz may not be unique. those should be
  renamed by adding pkgname, f.e.: ${pkgname}-${pkgver}.tar.gz::https...

- any use of $pkgdir must be put into double-quotes as they
  may contain spaces. (prepare() function)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: OpenPGP digital signature
URL: <https://lists.archlinux.org/pipermail/aur-general/attachments/20161020/beca7ac4/attachment.asc>