[aur-general] Review request, jedit-pkgbuild-edit-mode

[Vitaliy Berdinskikh]

Hi all,

I've updated the package:

* replace sources with downloaded tarball
* fix md5sums, add sha256sums
* add quotes to $pkgdir and $srcdir
* fix package name: jedit-pkgbuild-edit-mode -> jedit-pkgbuild
* update the install script with new package name
* rewrite the install script: now it doesn't use temporary softlinks to
modify files

Note why I modify catalog(catalog.xml) with xmlstarlet.

The file /usr/share/java/jedit/modes/catalog is part of the package [jedit](
https://www.archlinux.org/packages/community/any/jedit/).
I need to add new record for the PKGBUILD edit mode: to point my edit mode
file pkgbuild.xml. So after install I add this record and remove it before
uninstall.

PKGBUILD
~~~~~~~~
# Maintainer: Vitaliy Berdinskikh <ur6lad at gmail dot com>
pkgname=jedit-pkgbuild
pkgver=4.0.0
pkgrel=1
pkgdesc='jEdit PKGBUILD edit mode'
arch=('any')
url='https://bitbucket.org/ur6lad/jedit-pkgbuild'
license=('GPL')
depends=('jedit' 'xmlstarlet')
install=jedit-pkgbuild.install
source=(https://bitbucket.org/ur6lad/$pkgname/get/$pkgver.tar.bz2)
noextract=($pkgver.tar.bz2)
md5sums=('f9ab018b0a281d18e1ead326c4654757')
sha256sums=('c0b6f9360a8f7e4f6dc20ebdb0af286c5cd137c4fb73c1ed0b4eff245f52f0e8')

prepare() {
cd "$srcdir"

tar -xf $pkgver.tar.bz2 --strip-components=1
}

package() {
#  catalog,dtd is required to edit the edit mode catalog (XML)
mkdir -p "$pkgdir"/usr/share/$pkgname
install -m 644 "$srcdir"/catalog.dtd $pkgdir/usr/share/$pkgname/catalog.dtd

# edit mode file
mkdir -p "$pkgdir"/usr/share/java/jedit/modes
install -m 644 "$srcdir"/pkgbuild.xml
$pkgdir/usr/share/java/jedit/modes/pkgbuild.xml
}
~~~~~~~~

jedit-pkgbuild.install
~~~~~~~~
post_install() {
ln -s /usr/share/java/jedit/modes/catalog
/usr/share/jedit-pkgbuild/catalog.xml

xmlstarlet sel -Q -t -c //MODE[@FILE_NAME_GLOB=\"PKGBUILD\"]
/usr/share/jedit-pkgbuild/catalog.xml && xmlstarlet ed -L -d
//MODE[@FILE_NAME_GLOB=\"PKGBUILD\"] /usr/share/jedit-pkgbuild/catalog.xml
xmlstarlet ed -L -s /MODES -t elem -n MODE -i //MODE[last\(\)] -t attr -n
NAME -v PKGBUILD -i //MODE[last\(\)] -t attr -n FILE -v pkgbuild.xml -i
//MODE[last\(\)] -t attr -n FILE_NAME_GLOB -v PKGBUILD
/usr/share/jedit-pkgbuild/catalog.xml
}

pre_remove() {
xmlstarlet ed -L -d //MODE[@FILE_NAME_GLOB=\"PKGBUILD\"]
/usr/share/jedit-pkgbuild/catalog.xml

rm /usr/share/jedit-pkgbuild/catalog.xml
}
~~~~~~~~

If it's OK I will push the package to AUR.

-- 
Regards,
Vitaliy Berdikskikh AKA UR6LAD <http://ur6lad.co.ua/>
73!