[aur-general] Review request, jedit-pkgbuild-edit-mode

[Rafael Fontenelle]

2017-07-15 7:15 GMT-03:00 Vitaliy Berdinskikh via aur-general <
aur-general at archlinux.org>:

>
> PKGBUILD
> ~~~~~~~~
> # Maintainer: Vitaliy Berdinskikh <ur6lad at gmail dot com>
> pkgname=jedit-pkgbuild
> pkgver=4.0.0
> pkgrel=1
> pkgdesc='jEdit PKGBUILD edit mode'
> arch=('any')
> url='https://bitbucket.org/ur6lad/jedit-pkgbuild'
> license=('GPL')
> depends=('jedit' 'xmlstarlet')
> install=jedit-pkgbuild.install
> source=(https://bitbucket.org/ur6lad/$pkgname/get/$pkgver.tar.bz2)
>

I suggest setting your source to

source=($pkgname-$pkgver.tar.bz2::
https://bitbucket.org/ur6lad/$pkgname/get/$pkgver.tar.bz2)

so the downloaded tarball will be named jedit-pkgbuild-4.0.0.tar.bz2,
instead of just 4.0.0.tar.bz2 (more info about this solution
<https://wiki.archlinux.org/index.php/PKGBUILD#source>). This is
particularly useful to ease identification of the tarball when makepkg.conf
has $SRCDEST enabled, which stores all sources data in one directory
<https://wiki.archlinux.org/index.php/Makepkg#Configuration>.



> noextract=($pkgver.tar.bz2)
> md5sums=('f9ab018b0a281d18e1ead326c4654757')
> sha256sums=('c0b6f9360a8f7e4f6dc20ebdb0af286c5cd137c4fb73c1ed0b4eff245f52
> f0e8')
>
> prepare() {
> cd "$srcdir"
>
> tar -xf $pkgver.tar.bz2 --strip-components=1
> }
>
> package() {
> #  catalog,dtd is required to edit the edit mode catalog (XML)
> mkdir -p "$pkgdir"/usr/share/$pkgname
> install -m 644 "$srcdir"/catalog.dtd $pkgdir/usr/share/$pkgname/
> catalog.dtd
>
> # edit mode file
> mkdir -p "$pkgdir"/usr/share/java/jedit/modes
> install -m 644 "$srcdir"/pkgbuild.xml
> $pkgdir/usr/share/java/jedit/modes/pkgbuild.xml
>

Missing quotes for $pkgdir.

Also, the install location for pkgbuild.xml seems to be in a different line
of the 'install' command. It could be just the email adding a wrapped line,
but just to make sure it is correct.

}
> ~~~~~~~~
>
> jedit-pkgbuild.install
> ~~~~~~~~
> post_install() {
> ln -s /usr/share/java/jedit/modes/catalog
> /usr/share/jedit-pkgbuild/catalog.xml