[aur-general] Package review request
scimmia at archlinux.info
Wed Mar 15 15:10:00 UTC 2017
On Wed, 15 Mar 2017 15:41:27 +0100
Stefan Auditor via aur-general <aur-general at archlinux.org> wrote:
> Hi list,
> creating a PKGBUILD for Traefik, a reverse proxy, I would like to
> have it reviewed, as this is the first package I do that is containing
> a service.
> I tried following the Arch packaging standards but am fairly sure I
> missed things.
> Other than that it's a Golang project, so I just have a binary and some
> configuration files to package.
> Thank you for your time.
>  https://aur.archlinux.org/packages/traefik-bin/
>  https://github.com/containous/traefik
>  https://wiki.archlinux.org/index.php/Arch_packaging_standards
The biggest problem is that is will fail on a lot of setups. You don't have the
service, logrotate file, etc in the source array and assume that they're one
dir up from $srcdir. This is wrong.
Why do you have the LICENSE.md in both source_* arrays instead of the normal
source array? You should also not be pulling that from master, as you don't
know when that will change. It should be put in a subdir of $pkgname, not
chowning a managed dir in post_install is less than idea. You should be using a
set UID/GID and chowing it in the package function. You should also not be
deleting the user in post_remove.
Hope this helps!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 488 bytes
Desc: OpenPGP digital signature
More information about the aur-general