[aur-general] TU Application: Andrew Crerar

[Eli Schwartz]

On 11/21/2017 11:41 AM, Andrew Crerar wrote:
> I double checked this one and I am adding git-shell to /etc/shells within the 
> install file [2]. This is the same behavior as git in [extra] [3].

Whoops, I must have gotten confused while `diff`ing your files against
the version in extra.

> I dug around a bit and found this ticket [4] where it seems if you didn't have 
> hdf5 as a makedepends, then the build would fail (I personally don't think it 
> should have failed given the documentation [5]). This really should be 
> optdepends now since you can build without it. Fixed. I also took the liberty of 
> adding opencv-samples to the conflicts array (since opencv-git provides samples 
> without the split package).

As anthraxx said... I have no personal experience with the package but
it should either be a makedepends+optdepends as with the non-git
package, or if something has changed in git and it cannot be made
optional it shouldn't be both a depends and an optdepends.

-- 
Eli Schwartz

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.archlinux.org/pipermail/aur-general/attachments/20171121/57622600/attachment-0001.asc>