[aur-general] [Review Request] PKGBUILD for bumblebee-status

[Tobias Witek]

Hello,

I'm the maintainer of a tiny small python project for i3 users 
(https://github.com/tobi-wan-kenobi/bumblebee-status). Turns out most of 
the people using it seem to be Arch users, so I'd like to provide an AUR 
package.

Since I am not familiar with Arch myself, I'd kindly ask you to please 
have a look at the attached PKGBUILD just to make sure I'm not breaking 
anything for a majority of users (I will freely admit I have no clue 
what I am doing when it comes to building AUR packages).

In particular, I am unsure about:

* There is a git-based AUR already 
(https://aur.archlinux.org/packages/bumblebee-status-git/), the attached 
PKGBUILD is intended to be based on release-versions instead of the 
latest 'master'. Is it OK to use the same provides/conflicts in this case?

* Since the sources are a git repo, I don't know how to provide any 
checksums for the package. Any insights on that would be much appreciated.

Thank you very much for any input you can provide!

Kr,

Tobias
-------------- next part --------------
# Maintainer: Tobias Witek <tobi at tobi-wan-kenobi.at>

_pkgname=bumblebee-status
pkgname=bumblebee-status
pkgver=v1.4.2
pkgrel=1
pkgdesc="A modular, theme-able status line generator for the i3 window manager."
arch=('any')
url="https://github.com/tobi-wan-kenobi/bumblebee-status"
license=('MIT')
depends=('python-netifaces' 'python-psutil' 'python-requests')
optdepends=('xorg-xbacklight: To display a displays brightness'
	'xorg-xset: Enable/disable automatic screen locking'
	'libnotify: Enable/disable automatic screen locking'
	'dnf: Display DNF package update information'
	'xorg-setxkbmap: Display/change the current keyboard layout'
	'redshift: Display the redshifts current color'
	'pulseaudio: Control pulseaudio sink/sources'
	'xorg-xrandr: Enable/disable screen outputs'
    'pacman: Display current status of pacman'
    'iputils: Display a ping'
	'i3ipc: Display titlebar'
    'fakeroot: Dependency of the pacman module')
makedepends=('git')
provides=("${_pkgname}")
conflicts=("${_pkgname}")

source=('git+https://github.com/tobi-wan-kenobi/bumblebee-status')
md5sums=('SKIP')

pkgver() {
	cd "$srcdir/${_pkgname%}"
	printf "$(git tag | tail -n1)"
}

package() {
	cd "$srcdir/${_pkgname}"

	git checkout tags/$(git tag | tail -n1)

	mkdir -p "${pkgdir}/usr/share/${_pkgname}"
	install -m755 "${_pkgname}" "${pkgdir}/usr/share/${_pkgname}/"

	mkdir -p "${pkgdir}/usr/share/${_pkgname}/bumblebee"
	install -Dm644 "bumblebee/"*.py "${pkgdir}/usr/share/${_pkgname}/bumblebee/"

	mkdir -p "${pkgdir}/usr/share/${_pkgname}/bumblebee/modules"
	install -Dm644 "bumblebee/modules/"*.py "${pkgdir}/usr/share/${_pkgname}/bumblebee/modules/"

	mkdir -p "${pkgdir}/usr/share/${_pkgname}/themes"
	install -Dm644 "themes/"*.json "${pkgdir}/usr/share/${_pkgname}/themes/"

	mkdir -p "${pkgdir}/usr/share/${_pkgname}/themes/icons"
	install -Dm644 "themes/icons/"*.json "${pkgdir}/usr/share/${_pkgname}/themes/icons/"

	install -D -m644 LICENSE "${pkgdir}/usr/share/licenses/${pkgname}/LICENSE"

	mkdir -p "${pkgdir}/usr/bin"
	ln -rs "${pkgdir}/usr/share/${_pkgname}/bumblebee-status" "${pkgdir}/usr/bin/${_pkgname}"
}