[aur-general] Critique my pkgbuild

[Michael Straube]

>Hello again,
>
>It took me a while to have some time, but I believe I have fixed all of the issues that were pointed out to me, with >some help from Scimmia and eschwartz. I think the package is in much more presentable shape, I have learned plenty, and >I fixed a lot of naive mistakes. Thanks everyone for the help.
>
>I would very much appreciate it if you would all take the time to read the latest PKGBUILD (from the git version of the >package) pasted below and see if there is anything I missed. Thanks!

Hi Ethan,
for git repos that have tags containing a release version number it is common
to have a pkgver function that generates a pkgver that includes the version.

In this case e.g.

git describe --long --tags | sed 's/^master-v//;s/\([^-]*-g\)/r\1/;s/-/./g'

Regards,
Michael