[aur-general] New to makepkg, can someone have a look at my scripts?

Tue May 14 21:47:32 UTC 2019

Thanks for your input Stelios and Robin!

I've updated the pkgbuilds with your suggestions.

The file that I'm backing up in canu's pkgbuild, is a config file to
configure canu to run in grid mode and/or limiting resource usage. Moving
that file would require patching the source code, and I'm not up for that
task (yet :P).

Best regards

Roberto R.

On Tue, 14 May 2019 at 14:00, <aur-general-request at archlinux.org> wrote:

> Send aur-general mailing list submissions to
>         aur-general at archlinux.org
>
> To subscribe or unsubscribe via the World Wide Web, visit
>         https://lists.archlinux.org/listinfo/aur-general
> or, via email, send a message with subject or body 'help' to
>         aur-general-request at archlinux.org
>
> You can reach the person managing the list at
>         aur-general-owner at archlinux.org
>
> When replying, please edit your Subject line so it is more specific
> than "Re: Contents of aur-general digest..."
> Today's Topics:
>
>    1. Re: New to makepkg, can someone have a look at my scripts?
>       (Robin Broda)
>    2. Evolvotron app in AUR can't use correct distro libraries
>       (Saverio Brancaccio)
>    3. Re: Evolvotron app in AUR can't use correct distro libraries
>       (Jelle van der Waa)
>    4. Re: Evolvotron app in AUR can't use correct distro libraries
>       (Saverio Brancaccio)
>
>
>
> ---------- Forwarded message ----------
> From: Robin Broda <arch-ml at coderobe.net>
> To: aur-general at archlinux.org
> Cc:
> Bcc:
> Date: Mon, 13 May 2019 16:30:35 +0200
> Subject: Re: [aur-general] New to makepkg, can someone have a look at my
> scripts?
> On 5/13/19 1:20 PM, Roberto Rossini wrote:
> > Can someone please check if they are ok and maybe give me some feedback
> on
> > things that I can improve?
> >
> >    - Canu - https://aur.archlinux.org/packages/canu/
>
> - please don't end $pkgdesc with punctuation
> - 'canu' shouldn't be in provides=(), as a package implicitly provides
> itself
> - 'canu' shouldn't be in conflicts=() - this is impossible
> - why is there a backup=() entry for a file in /usr/bin/?
> - line 26 $srcdir may contain spaces and should thus be quoted to prevent
> word splitting
> - line 32 $srcdir may contain spaces and should thus be quoted to prevent
> word splitting
> - line 37 $srcdir may contain spaces and should thus be quoted to prevent
> word splitting
> - line 40 $file may contain spaces and should thus be quoted to prevent
> word splitting
> - line 40 $pkgdir may contain spaces and should thus be quoted to prevent
> word splitting
> - line 44 $file may contain spaces and should thus be quoted to prevent
> word splitting
> - line 40 $pkgdir may contain spaces and should thus be quoted to prevent
> word splitting
> - line 47 $pkgdir may contain spaces and should thus be quoted to prevent
> word splitting
> - line 48 $pkgdir may contain spaces and should thus be quoted to prevent
> word splitting
> - line 50 $srcdir may contain spaces and should thus be quoted to prevent
> word splitting
> - line 51 $pkgdir may contain spaces and should thus be quoted to prevent
> word splitting
> - line 52 $pkgdir may contain spaces and should thus be quoted to prevent
> word splitting
>
> also, fwiw, `cd $srcdir` is a no-op as a first command in any of these
> functions,
> they all implicitly start in $srcdir
>
>
> >    - StringTie - https://aur.archlinux.org/packages/stringtie/
>
> - please don't end $pkgdesc with punctuation
> - 'stringtie' shouldn't be in provides=(), as a package implicitly
> provides itself
> - 'stringtie' shouldn't be in conflicts=() - this is impossible
> - line 23 $srcdir may contain spaces and should thus be quoted to prevent
> word splitting
> - line 29 $srcdir may contain spaces and should thus be quoted to prevent
> word splitting
> - line 34 $srcdir may contain spaces and should thus be quoted to prevent
> word splitting
> - line 36 $srcdir may contain spaces and should thus be quoted to prevent
> word splitting
> - line 36 $pkgdir may contain spaces and should thus be quoted to prevent
> word splitting
> - line 38 $pkgdir may contain spaces and should thus be quoted to prevent
> word splitting
> - line 38 the license 'Artistic2.0' is a common license and does not need
> to be installed explicitly
>
>
> >    - Diamond-git -
> https://aur.archlinux.org/packages/diamond-aligner-git/
>
> - please don't end $pkgdesc with punctuation
> - 'git' should be part of makedepends=() as it is required to pull
> git+https sources
> - line 55 the license 'GPL3' is a common license and does not need to be
> installed explicitly
>
>
> >
> > Best regards
> >
> > Roberto R.
> >
>
>
> Hope that helps :)
>
> Take a look at https://coderobe.net/pkgbuild for an experimental (and
> forever incomplete) sanity checker.
> It can catch some of these issues automagically ;)
>
> Regards
> --
> Rob (coderobe)
>
> O< ascii ribbon campaign - stop html mail - www.asciiribbon.org
>
>
>
>
> ---------- Forwarded message ----------
> From: Saverio Brancaccio <saverio.brancaccio at gmail.com>
> To: aur-general at archlinux.org
> Cc:
> Bcc:
> Date: Tue, 14 May 2019 07:32:59 +0200
> Subject: [aur-general] Evolvotron app in AUR can't use correct distro
> libraries
> Hi, can you give any feedback on why there is this segmentation fault when
> installing and running this app from AUR? Thanks in andvance
>
> https://aur.archlinux.org/packages/evolvotron/
>
>
>
>
> ---------- Forwarded message ----------
> From: Jelle van der Waa <jelle at vdwaa.nl>
> To: "Discussion about the Arch User Repository (AUR)" <
> aur-general at archlinux.org>
> Cc:
> Bcc:
> Date: Tue, 14 May 2019 09:14:14 +0200
> Subject: Re: [aur-general] Evolvotron app in AUR can't use correct distro
> libraries
> On 05/14/19 at 07:32am, Saverio Brancaccio via aur-general wrote:
> > Hi, can you give any feedback on why there is this segmentation fault
> when
> > installing and running this app from AUR? Thanks in andvance
> >
> > https://aur.archlinux.org/packages/evolvotron/
>
> Please pastebin the segmentation fault somewhere...
>
> The PKGBUILD hardcodes `make -j4` which is wrong, change that at least
> to just `make` since otherwise your machine my run out of ram depending
> on your hardware.
>
> --
> Jelle van der Waa
>
>
>
> ---------- Forwarded message ----------
> From: Saverio Brancaccio <saverio.brancaccio at gmail.com>
> To: "Discussion about the Arch User Repository (AUR)" <
> aur-general at archlinux.org>
> Cc:
> Bcc:
> Date: Tue, 14 May 2019 09:18:46 +0200
> Subject: Re: [aur-general] Evolvotron app in AUR can't use correct distro
> libraries
> Thanks for the attention,
> you can look at the core dump generated after that I tried to run
> Evolvotron application at the following link:
> https://bbs.archlinux.org/viewtopic.php?pid=1844227#p1844227
>
> Il giorno mar 14 mag 2019 alle ore 09:14 Jelle van der Waa <jelle at vdwaa.nl
> >
> ha scritto:
>
> > On 05/14/19 at 07:32am, Saverio Brancaccio via aur-general wrote:
> > > Hi, can you give any feedback on why there is this segmentation fault
> > when
> > > installing and running this app from AUR? Thanks in andvance
> > >
> > > https://aur.archlinux.org/packages/evolvotron/
> >
> > Please pastebin the segmentation fault somewhere...
> >
> > The PKGBUILD hardcodes `make -j4` which is wrong, change that at least
> > to just `make` since otherwise your machine my run out of ram depending
> > on your hardware.
> >
> > --
> > Jelle van der Waa
> >
>
> _______________________________________________
> aur-general mailing list
> aur-general at archlinux.org
> https://lists.archlinux.org/listinfo/aur-general
>