[aur-requests] [PRQ#12177] Orphan Request for quassel-light Rejected

[Oleg Shparber]

I've fixed the typo, and added some makedepends. Frankly it's the first
time someone noticed that qmake may be not installed.

As for rm -r, it's exactly what the package in community has [1], and my
goal was to keep it my PKGBUILD as close to that as possible. And rm -r
worked for me just fine.

Can't test building in chroot right away, but will do shortly. I can also
add a co-maintainers, no problem there.

1.
https://git.archlinux.org/svntogit/community.git/tree/trunk/PKGBUILD?h=packages/quassel#n91

Cheers,
Oleg


On Sun, Aug 12, 2018 at 5:58 PM Eli Schwartz <eschwartz at archlinux.org>
wrote:

> On 8/12/18 2:59 PM, Stephan Springer wrote:
> > notify at aur.archlinux.org schrieb am 12.08.18 16:22:
> >> Request #12177 has been rejected by Eschwartz [1]:
> >>
> >> maintainer updated
> >>
> >> [1] https://aur.archlinux.org/account/Eschwartz/
> >
> > Yes, the maintainer did indeed two uploads, but the build is still
> > broken (two missing backslashes and an invalid «rm -r», see my comments
> > on https://aur.archlinux.org/pkgbase/quassel-light/). By the way, I just
> > noticed another typo in line 97 of PKGBUILD: quasslel-client should read
> > quassel-client.
> >
> > Cheers
>
> Oops, I guess I rejected this too soon. Now that I've taken a closer
> look, it also seems to be missing a makedepends on Qt5... building in a
> clean chroot results in:
>
> CMake Error at CMakeLists.txt:185 (message):
>   Could NOT find Qt5 >= version 5.2.0!
>
>
> --
> Eli Schwartz
> Bug Wrangler and Trusted User
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.archlinux.org/pipermail/aur-requests/attachments/20180812/a248ca27/attachment.html>