[pacman-dev] script spaces/tabs, modelines, etc.
Dan McGee
dpmcgee at gmail.com
Mon Dec 18 12:45:50 EST 2006
Since I've been working on the makepkg script a decent amount, I
noticed it had no vim modeline. I also noticed that many of the other
scripts do not have a modeline, others are inconsistant, and the abs
script actually has 2:
$ grep vim *
abs:# vim: set ft=sh ts=2 sw=2
abs:# vim: set ts=2 noet:
gensync:# vim: set ts=2 sw=2 noet:
rankmirrors:# vim: set ts=4 sw=4 sta et sts ai:
The rankmirrors one is going to be a bit different because it is a
python script, but should we standardize some sort of thing for the
bash/sh scripts? Right now the makepkg script is starting to turn into
an interesting mix of tabs and spaces, especially if someone uses a ts
size different than 4.
Here is my take on the situation:
1. Update the modeline for abs- ft should be detected anyway, and no
need for two modelines.
2. Standardize the inclusion of the modeline used by the gensync
script across all bash scripts included with pacman. It makes sense to
have one standard and this seems to be the one most readily available
for scripting. Always place this modeline as the last line of the
file.
If spacing/tabs is a no-no here, I apologize. :)
-Dan
More information about the pacman-dev
mailing list