[pacman-dev] [7] remove exit() calls from libalpm

Aurelien Foret aurelien at archlinux.org
Tue Feb 7 14:05:21 EST 2006

VMiklos wrote:
> On Mon, Feb 06, 2006 at 11:18:08PM +0100, Aurelien Foret <aurelien at archlinux.org> wrote:
>> [7] remove exit() calls from libalpm
>> the library should never call exit() but always return an error code to
>> the frontend (for instance, drop MALLOC macro)
> hmm, is it really necessary to drop that macro?
> what about this patch?
> http://darcs.frugalware.org/darcsweb/darcsweb.cgi?r=pacman;a=plain_commitdiff;h=20060207134351-e2957-b0df11f6b20863c6ca6c097bb78780bcd3ceaf97.gz;

I don't think it would fit: it drops all possibilities to take needed 
actions to cleanup the environment (freeing locally allocated memory, 
...) before leaving a function.

Anyway, it is only used 6 times in the whole library... not a big deal 
to remove it.

More information about the pacman-dev mailing list