[pacman-dev] [7] remove exit() calls from libalpm

[VMiklos]

On Tue, Feb 07, 2006 at 08:05:21PM +0100, Aurelien Foret <aurelien at archlinux.org> wrote:
> VMiklos wrote:
> > On Mon, Feb 06, 2006 at 11:18:08PM +0100, Aurelien Foret <aurelien at archlinux.org> wrote:
> >> [7] remove exit() calls from libalpm
> >> the library should never call exit() but always return an error code to
> >> the frontend (for instance, drop MALLOC macro)
> > 
> > hmm, is it really necessary to drop that macro?
> > what about this patch?
> > http://darcs.frugalware.org/darcsweb/darcsweb.cgi?r=pacman;a=plain_commitdiff;h=20060207134351-e2957-b0df11f6b20863c6ca6c097bb78780bcd3ceaf97.gz;
> 
> I don't think it would fit: it drops all possibilities to take needed 
> actions to cleanup the environment (freeing locally allocated memory, 
> ...) before leaving a function.

ok, here is an updated patch:
http://frugalware.org/~vmiklos/patches/libpacman-proposed/drop_malloc.diff

i haven't added any extra FREE() for other allocated memory, if the
patch is ok, then i can add

udv / greetings,
VMiklos

-- 
Developer of Frugalware Linux, to make things frugal - http://frugalware.org