[pacman-dev] Little problem with -Qm option (for foreign packages)

[x.chantry at wanadoo.fr]

On Tue, 16 May 2006 22:48:42 +0200
VMiklos <vmiklos at frugalware.org> wrote:

> On Tue, May 16, 2006 at 10:17:28PM +0200, x.chantry at wanadoo.fr wrote:
> > I was thinking about comparing the length of the strings first, before strstr.
> 
> i don't remember why i've used strstr(), strcmp() would solve the issue
> imho
> 
> > What about the conversion to uppercase? is it really needed?
> 
> since the packages are lowercase, it makes no sense. probably not needed
> just i've borrowed the ide from the old -Ss/Qs code
> 

Ha yes, silly me, here is the new patch with strcmp. It still removes
the conversion to uppercase since you confirm what I thought.
Thanks.

XC
-------------- next part --------------
A non-text attachment was scrubbed...
Name: foreign.diff
Type: application/octet-stream
Size: 872 bytes
Desc: not available
URL: <http://archlinux.org/pipermail/pacman-dev/attachments/20060516/9df4cfaa/attachment.obj>