[pacman-dev] coloured pacman

[Roman Kyrylych]

2007/2/6, Aaron Griffin <aaronmgriffin at gmail.com>:
> On 2/6/07, Vojtěch Gondžala <vogo at seznam.cz> wrote:
> > Hi all,
> >
> > this patch add coloured output in to pacman-3.0.0
> >
> > diff is here: http://www.fi.muni.cz/~xgondz/pacman3-color/pacman3-color.diff
>
> I think the general consensus is that coloring pacman output is bad,
> but I really have no technical opinion.
>
> Two things, about your patch:
> a) Could you set this up to include a pacman.conf setting (maybe
> UseColor) and only output color when that is true.
>
> b) Could you please send the patch in unified diff format, it makes it
> easier for us to see the changes you made and comment on them (see
> submitting-patches at the top of pacman CVS's root).
>
> Thanks for the patch!
>
> Does anyone have strong opinions either way about color?  I for one
> don't care that much, as long as I can shut it off.

I don't mind about color. Anyway makepkg and initscripts do use
colored messages, so why not pacman? Of course it can be customizable
(I would prefer common way of doing this in makepkg, initscripts and
pacman) and optional (UseColor in pacman.conf), and of course it
shouldn't add complexity to code.
This patch is hard to read (because it's not unified diff) but as I
see it would be better to do not change MSG(NL, ...) to MSG(NL,
color(...)), but instead change MSG itself - this would be much
cleaner way, IMO.

-- 
Roman Kyrylych (Роман Кирилич)