[pacman-dev] [patch] removedeps

[ngaba at petra.hos.u-szeged.hu]

> This is a line from your original patch there :
> http://www.archlinux.org/pipermail/pacman-dev/2007-June/008539.html
> + * assumptions: alpm_list_add adds new member to the end of the list, so we
> can reuse the list pointer
Well, then I wasn't clear here (or I changed the function and forgot 
about this comment, I don't remember yet;-).

> IMO it isn't necessarily the end, as long as it adds after the first element.
> I think this assumption is needed now with the way you changed the 
> function (adding the
> new elements to the list passed in argument, instead of returning a new
> list).
> But when using **targs, we don't need that.
Oh, I see, you are right, similarly for alpm_resolvedeps (we talked 
about this yesterday):-P

> What do you mean there ?
I put the removedeps call after topo sort for efficiency, so this 
should be rejected until the topo-sort invariancy is not guaranteed.

> If we remove the while(!ready) loop, we will indeed need to sort the 
> list before.
IMHO no :-P

Bye, ngaba.


----------------------------------------------------------------
This message was sent using IMP, the Internet Messaging Program.