[pacman-dev] [patch] resolvedeps cleanup + pactest

[Dan McGee]

On 7/14/07, ngaba at petra.hos.u-szeged.hu <ngaba at petra.hos.u-szeged.hu> wrote:
> > +                     sync = _alpm_db_get_pkgfromcache(j->data, missdep->name);
> > +                     found = alpm_depcmp(sync, missdep);
> Hi!
> Since sync can be NULL here (if not found), if (sync =
> _alpm_db_get_pkgfromcache(j->data, missdep->name)) found =
> alpm_depcmp(sync, missdep);
> would be better imho.
> Bye, ngaba

I'm glad you are so willing to help us improve pacman, but I really
just groan when I see something like the above.

Even if it isn't a patch, can you at least try to using spacing and
line breaks properly? This goes for both code and discussion.

Thanks.

-Dan