[pacman-dev] [patch] resolvedeps cleanup + pactest

Xavier shiningxc at gmail.com
Sat Jul 14 16:09:57 EDT 2007


On Sat, Jul 14, 2007 at 09:40:37PM +0200, ngaba at petra.hos.u-szeged.hu wrote:
> > +			sync = _alpm_db_get_pkgfromcache(j->data, missdep->name);
> > +			found = alpm_depcmp(sync, missdep);
> Hi!
> Since sync can be NULL here (if not found), if (sync = 
> _alpm_db_get_pkgfromcache(j->data, missdep->name)) found = 
> alpm_depcmp(sync, missdep);
> would be better imho.

Oops, you're perfectly right, thanks. I fixed it.
Otherwise, it looks ok ?




More information about the pacman-dev mailing list