[pacman-dev] TotalDownload option.

[Dan McGee]

On Nov 11, 2007 7:21 AM, Nathan Jones <nathanj at insightbb.com> wrote:
> On Sat, Nov 10, 2007 at 12:14:27AM -0500, Eric Belanger wrote:
> > On Sat, 10 Nov 2007, Xilon wrote:
> >
> > > On Nov 10, 2007 9:54 AM, Nathan Jones <nathanj at insightbb.com> wrote:
> > >> :: Retrieving packages from core...
> > >>  gcc-libs-4.2.2-2-i686   1081.1K  665.7K/s 00:00:02 [#####################]   8%
> > >>  gcc-4.2.2-3-i686          10.0M 1009.0K/s 00:00:10 [#####################]  77%
> > >> :: Retrieving packages from extra...
> > >>  gcc-fortran-4.2.2-1-...   12.9M  926.2K/s 00:00:14 [#####################] 100%
> > >> checking package integrity... done.
> > >> (3/3) checking for file conflicts                   [#####################] 100%
> > >> (1/3) upgrading gcc-libs                            [#####################] 100%
> > >> (2/3) upgrading gcc                                 [#####################] 100%
> > >> (3/3) upgrading gcc-fortran                         [#####################] 100%
> > >
> > > IMO it is a bit confusing to see the progress bar completed while the
> > > percentage isn't 100%, especially when people don't expect this
> > > behaviour.
>
> Remember that the user has to explicitly enable the TotalDownload option
> to get this behavior. The pacman.conf man page will state that the
> progress bar is still the percentage of the current file. If the user is
> confused he can just go back to the old way.
>
> > > It would be better if there was some indication that the
> > > percentage is the total progress. It would be best is there was a
> > > "total" progress bar underneath or something, to actually separate
> > > them, but that would probably require too many alterations to the code
> > > for the little benefit it would give.
>
> pacman emits a carriage return (not a newline) after the download line
> to return to the beginning of the line. I don't know how to print two
> lines and return to the beginning of the first.
>
> > Why not put two percentages: one for the current package progress and one
> > for the total packages percent? I'm not sure how to display them in a way
> > that'll be user-friendly.
>
> Here are two possibilities. I personally don't like either of them, but
> I'll change it if I get enough pennies thrown at me again.

I like this new set of patches, and as Nathan stated, a user has to
explicitly enable TotalDownload so they will not be confused with what
is going on. For now I'll pull these set of patches; if we want to
change something we can patch things up again in the future.

-Dan