[pacman-dev] Segmentation fault

Aaron Griffin aaronmgriffin at gmail.com
Thu Nov 15 15:17:57 EST 2007


On Nov 15, 2007 2:08 PM, Dan McGee <dpmcgee at gmail.com> wrote:
>
> On Nov 15, 2007 1:21 PM, Aaron Griffin <aaronmgriffin at gmail.com> wrote:
> > On Nov 15, 2007 1:09 PM, Dan McGee <dpmcgee at gmail.com> wrote:
> > > It is actually not a blank server, but a file:// URL which sets the
> > > server part to null or "" (hopefully, otherwise we could have a
> > > segfault here). Thus, only the path is set. I'm sure we can find a way
> > > to make this message more clear.
> >
> > I noticed that later too...
> >
> > http://code.phraktured.net/?p=pacman.git;a=commitdiff;h=c10aa2d7c9fd37a3f8f077dc874c04bb5a6140a6
> >
> > Still, the original segfault remains.
>
> Not to be nitpicky, but that could be a false test case (if the server
> name did not get set for some reason). Why not use strcmp(SCHEME_FILE,
> url->scheme)?

True and all but if there's no host name, and it's not a file url we
shouldn't be at that point in the code

Either way, I'll change it




More information about the pacman-dev mailing list