[pacman-dev] Submitting Patches

[Aaron Griffin]

On 10/24/07, Dan McGee <dpmcgee at gmail.com> wrote:
> Why am I being such a hard ass on this? Because I am beginning to lose
> motivation to merge other peoples changes when it take me more time to
> figure out how to review them then it did to make the change itself.
> And I'd like to enjoy working on pacman again. Right now I feel like
> there is a weight on my shoulders with all these shoddy patches lying
> around. I want that weight to be gone, and I want others to be able to
> review patches just as easily as I should.

Well said.

Let me add this to. For those of use that code for a living, and do
this day in and day out, code is a better explanation than English.
Always. Here's an example:

a) "Change the index of the loop structure to advance twice as fast"
b)
- for(int i=0; i<10; i++)
+ for(int i=0; i<10; i+=2)


It's a matter of transferring knowledge. If you want to tell someone
something, and it's important, you'll want to transfer knowledge in
the best way possible.

I'm not going to send someone smoke signals when I can call them on
their cell phone, it's inefficient. By the same token, having to
convert English text to code is just as inefficient.