[pacman-dev] alpm_list_remove is buggy

Nagy Gabor ngaba at bibl.u-szeged.hu
Fri Oct 26 14:46:53 EDT 2007

That function seems totally odd.
/* TODO I modified this to remove ALL matching items.  Do we need a
remove_first? */ <- this is partly true:
*data contains only the last found "i->data", and the function doesn't
return with an alpm_list. MEMLEAK!!

Bye, ngaba

PS: I don't create a patch, because I dunno want do you want: remove
the matching _list_ or remove the first matching _item_'s data. My
vote: 2nd. (Because then I don't have to resubmit my -Ru patch ;-)

More information about the pacman-dev mailing list