[pacman-dev] Several output issues

[Xavier]

I wonder if the output of this mail won't be a problem in itself, but well
I'll give it a try at least.

While using pacman 3.1 , I've noticed several issues with the output.
Unfortunately I wasn't able to debug any of them, but thought I would share
them anyway, in case someone has a clue.

I noticed mostly two kinds of issues :

1) Issues with the messages / notifications from src/pacman/callback.c

> $ sudo LANG=C pacman -S xf86-video-i810
> resolving dependencies... done.
> :: xf86-video-i810 conflicts with xf86-video-intel. Remove xf86-video-intel? [Y/n] looking for inter-conflicts... 
> done.
>
> Remove: xf86-video-intel  
>
> Total Removed Size:   0.10 MB
> Targets: xf86-video-i810-1.7.4-6  

> Total Package Size:   3.55 MB
> Total Installed Size:   9.87 MB

> Proceed with installation? [Y/n] 

That "looking for inter-conflicts..." message looks a bit weird there.

> $ sudo LANG=C pacman -S xterm
> :: xterm-229-2: local version is up to date. Upgrade anyway? [Y/n] 
> resolving dependencies... done.
> looking for inter-conflicts... done.
>
> Targets: xterm-229-2  
>
> Total Package Size:   0.20 MB
>
> Proceed with installation? [Y/n] 
> :: Archive xterm-229-2.pkg.tar.gz is corrupted. Do you want to delete it? [Y/n] checking package integrity... 
> error: failed to commit transaction (corrupted package)
> archive xterm-229-2.pkg.tar.gz was corrupted (bad MD5 checksum)
> Errors occurred, no packages were upgraded.

Same for "checking package integrity..." here.


2) Issues with the progress bar (used in remove_commit and commit_single_pkg)

> $ sudo LANG=C pacman -R xorg-xinit xorg-twm
> loading package data... checking dependencies... done.
> warning: /etc/X11/twm/system.twmrc saved as /etc/X11/twm/system.twmrc.pacsave
> (1/2) removing xorg-twm                             [############################] 100%
> warning: /etc/skel/.xinitrc saved as /etc/skel/.xinitrc.pacsave------------------]   0%
> (2/2) removing xorg-xinit                           [############################] 100

> $ sudo LANG=C pacman -S xorg-xinit xorg-twm
> :: xorg-xinit-1.0.5-1: local version is up to date. Upgrade anyway? [Y/n] 
> :: xorg-twm-1.0.1-2: local version is up to date. Upgrade anyway? [Y/n] 
> resolving dependencies... done.
> looking for inter-conflicts... done.
>
> Targets: xorg-xinit-1.0.5-1  xorg-twm-1.0.1-2  
> 
> Total Package Size:   0.10 MB
>
> Proceed with installation? [Y/n] 
> checking package integrity... done.
> (2/2) checking for file conflicts                   [############################] 100%
> (1/2) upgrading xorg-xinit                          [############################] 100%
> warning: /etc/X11/twm/system.twmrc installed as /etc/X11/twm/system.twmrc.pacnew-]   0%
> (2/2) upgrading xorg-twm                            [############################] 100


> $ sudo LANG=C pacman -S filesystem
> :: filesystem-2007.08-2: local version is up to date. Upgrade anyway? [Y/n] 
> resolving dependencies... done.
> looking for inter-conflicts... done.
> 
> Targets: filesystem-2007.08-2  
>
> Total Package Size:   0.10 MB
>
> Proceed with installation? [Y/n] 
> checking package integrity... done.
> (1/1) checking for file conflicts                   [############################] 100%
> warning: directory permissions differ on proc/      [----------------------------]   0%
> filesystem: 555  package: 755(1/1) upgrading filesystem                          [############################] 100%


That last one is a bit particular, I think it was missed during that last
newline commit :
http://projects.archlinux.org/git/?p=pacman.git;a=commit;h=5c9eec5570c145c07660bd2ba207b579eda0f26c

But after adding newlines, it just behaves like the above ones, the messages
end with a progressbar, and it looks rather odd.

I think I see at least 2 workarounds for this problem :
* totally disable all these warnings during extraction
* buffer the messages, and display them only after all the files have been extracted.

There might be a better solution that doesn't require any of these though.
Wouldn't it be possible to just clear the line before outputting the messages,
or something like that, and let the progress bar redisplay itself on the next line?