[pacman-dev] [PATCH] makepkg : allow to specify a download filename

[Allan McRae]

Xavier wrote:
> On Sun, Aug 24, 2008 at 3:42 PM, Allan McRae <allan at archlinux.org> wrote:
>   
>> Looks good. A missing %o in DLAGENTS did need to be supported as the
>> makepkg.conf man pages says that it is optional. As a side note, the
>> description of %u being replaced by the url if present or the url being
>> placed at the end needs tidied up in the man page as it currently sounds
>> like putting the url at the end will alway happen.
>>
>>     
>
> What about this :
>
> DLAGENTS=('protocol::/path/to/command [options]' …)
>
>     Sets the download agents used to fetch source files specified with
> a URL in the PKGBUILD(5) file. Options can be specified for each
> command as well, and any protocol can have a download agent. Several
> examples are provided in the default makepkg.conf.
>     If present, instances of %u will be replaced with the download
> URL. Otherwise, the download URL will be placed on the end of the
> command. If present, instances of %o will be replaced with the local
> filename, plus a ".part" extension, which allows to do file resumes
> properly.
>
>   

Slight changes here.  I don't like "instances of" as that implies there 
can be multiple occurrences of each.  Also a tidy up of the grammar at 
the end.  I would prefer not to use "If present" twice as it does not 
read well, but can not think of a better way at this time of night...

    If present, %u will be replaced with the download URL. Otherwise, 
the download URL will be placed on the end of the command. If present, 
%o will be replaced with the local filename, plus a ".part" extension, 
which allows makepkg to handle resuming file downloads.