[pacman-dev] Thoughts of a 3.1.2 release

Xavier shiningxc at gmail.com
Fri Feb 8 17:01:42 EST 2008

Allan McRae wrote:
> I think these are really the same issue.  makepkg extracts files with
> the system umask, which if not sane can cause problems if file are then
> installed poorly.  I've added a comment in FS#9242 showing that I think
> the opera install.sh uses "cp" to install files.
> The only justification I can think of to fix this is if for some reason
> extracting with such permissions causes a package not to actually build.
> Then we should probably set the umask earlier. Can this happen other
> than with a really stupid umask?  Otherwise, a check of the current
> umask could be added and a warning printed if not 0022.

Ah yes, indeed, that's it. I couldn't figure that out alone :)
Well, attaching a patch to set the umask earlier.
That seems to work fine.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-makepkg-set-sane-umask-before-source-extraction.patch
Type: text/x-patch
Size: 1299 bytes
Desc: not available
URL: <http://archlinux.org/pipermail/pacman-dev/attachments/20080208/ac774a63/attachment.bin>

More information about the pacman-dev mailing list