[pacman-dev] [PATCH] makepkg: add --allsource option

Allan McRae mcrae_allan at hotmail.com
Mon Jun 2 10:27:09 EDT 2008


Miklos Vajna wrote:
> On Mon, Jun 02, 2008 at 06:47:36AM -0500, Dan McGee <dpmcgee at gmail.com> wrote:
>   
>> So what are you saying, did anyone actually look at the patch? I
>> didn't change the existing --source option one bit, that *still* only
>> includes local source files.
>>     
>
> yes, i read that patch :)
>
>   
>> All I did was add a completely new --allsource option that allows you
>> to also build an src.tar.gz with all source, local and remote. How
>> much more flexible can we get than having two options here?
>>     
>
> i just said that creating such a huge srpm-like tarball is a bad idea,
> and encouraging people to do so by adding an option for that is not
> something i would recommend. just my two cents, though.
>   

I see no problem with this.  It is an optional extra.  Nobody is being 
forced to use it or download the packages if someone else uses it.  And 
it is actually useful for those hosting custom repos as they can quickly 
create a complete source package to host for GPL(2?) compliance.

The only cost here is one extra if statement if you are using the 
--source option and another long option name to come up with an 
abbreviation for (if that idea goes ahead).  I.e. essentially zero.


Allan






More information about the pacman-dev mailing list