[pacman-dev] [PATCH] Move geninteg block in makepkg before error checking

Allan McRae mcrae_allan at hotmail.com
Mon May 26 02:46:49 EDT 2008


Allan McRae wrote:
> This pactch moves the generating of integrity checks to before any
> error checking takes place in the PKGBUILD file.  This allows integrity
> generation to complete when unrelated errors exist in a PKGBUILD file
> and allows the removal of multiple checks of the GENINTEG variable that
> would otherwise be needed.
>
> <snip>

This was part of a conglomerate patch I sent earlier which has now been 
split.

I like this move because it removes two checks of GENINTEG plus and 
additional check which would be needed in the block checking the arch 
array.  It now also skips all the other PKGBUILD checks which shouldn't 
cause an error when only generating the integrity checks.  However, it 
does put the geninteg code block in the middle of nowhere, but I suppose 
it is an awkward but helpful addition to makepkg anyway.

Allan




More information about the pacman-dev mailing list