[pacman-dev] [PATCH] Move geninteg block in makepkg before error checking
shiningxc at gmail.com
Mon May 26 04:17:21 EDT 2008
On Mon, May 26, 2008 at 8:46 AM, Allan McRae <mcrae_allan at hotmail.com> wrote:
> This was part of a conglomerate patch I sent earlier which has now been
> I like this move because it removes two checks of GENINTEG
Yes, I don't like much all these checks everywhere which control the
flow of makepkg.
> plus an
> additional check which would be needed in the block checking the arch
> array. It now also skips all the other PKGBUILD checks which shouldn't
> cause an error when only generating the integrity checks. However, it
> does put the geninteg code block in the middle of nowhere, but I suppose
> it is an awkward but helpful addition to makepkg anyway.
Well, I am still not fully convinced this is a good thing. All these
errors that makepkg can detect needs to be fixed. If you run makepkg
-g, it is usually after you have finished writing the PKGBUILD, so all
errors should be fixed at that step.
But if everyone else thinks otherwise (you, Roman, Dan), and that
these errors are irrelevant to makepkg -g which can indeed still be
run, then fine.
And in this case, I prefer the new patch over the old one.
More information about the pacman-dev