[pacman-dev] [PATCH] Use colon instead of dot separator for chown

Dan McGee dpmcgee at gmail.com
Tue May 27 15:43:30 EDT 2008

On Tue, May 27, 2008 at 2:26 PM, Aaron Griffin <aaronmgriffin at gmail.com> wrote:
> On Tue, May 27, 2008 at 2:22 PM, Sebastian Nowicki <sebnow at gmail.com> wrote:
>> On BSD systems using a dot as a separator is not allowed. On Mac OSX it
>> is deprecated. A colon should be used instead. BSD systems also use the
>> "wheel" group instead of "root" to indicate the "super user" group. Both
>> groups use the id of 0.
>> Signed-off-by: Sebastian Nowicki <sebnow at gmail.com>
> I want to do this because Dan always does!
> Acked-by: Aaron Griffin <aaronmgriffin at gmail.com>

Lol. We actually do patch review around here?
My only suggestion would be removal of the worthless comment and
replacing it by something better such as "change perms to root & root
user group on all systems" or something, as the current comment is
nothing more than a restatement than the code below it. With that
Acked-by: Dan McGee <dan at archlinux.org>

Now Xavier just needs to signoff and pull this in his tree and we'll
have a really well reviewed patch.


More information about the pacman-dev mailing list