[pacman-dev] [PATCH] Use colon instead of dot separator for chown

Xavier shiningxc at gmail.com
Wed May 28 03:59:54 EDT 2008


On Tue, May 27, 2008 at 9:22 PM, Sebastian Nowicki <sebnow at gmail.com> wrote:
> On BSD systems using a dot as a separator is not allowed. On Mac OSX it
> is deprecated. A colon should be used instead. BSD systems also use the
> "wheel" group instead of "root" to indicate the "super user" group. Both
> groups use the id of 0.
>
> Signed-off-by: Sebastian Nowicki <sebnow at gmail.com>
> ---
>  scripts/makepkg.sh.in |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in
> index cc44c68..1209bd0 100644
> --- a/scripts/makepkg.sh.in
> +++ b/scripts/makepkg.sh.in
> @@ -629,8 +629,8 @@ extract_sources() {
>        done
>
>        if [ $EUID -eq 0 ]; then
> -               # chown all source files to root.root
> -               chown -R root.root "$srcdir"
> +               # chown all source files to root:0
> +               chown -R root:0 "$srcdir"
>        fi
>  }


Oops, I forgot to do some communication.
When you started reporting macosx/bsd portability problems, I looked
back at an old mail which was taken a bit too seriously and turned
into a flamewar instead of something useful :
http://www.archlinux.org/pipermail/pacman-dev/2007-October/009659.html
So it mentioned du and cp problems, which you already found again.
I don't understand the source vs . one because source is bash builtin,
but Dan mentioned this already back then.
The last point was that chown problem so I patched it two days ago :
http://shining.toofishes.net/gitweb/gitweb.cgi?p=pacman.git;a=commitdiff;h=e10f9e0d79598a27d1e9c48ba0f063400537b2ef

Anyway I will merge the two patches and fix the comment like Dan said.
PS : For doing this, I need my wifi connection back at home, which
wasn't working yesterday evening and this morning. I hope it won't
last..




More information about the pacman-dev mailing list