[pacman-dev] [PATCH] makepkg: Make stripping debug symbols cross-platform

[Allan McRae]

Sebastian Nowicki wrote:
> The Linux and BSD versions of strip have the --strip-debug option (as
> well as the -S option), however Mac OS X only has -S.
> ---
>  scripts/makepkg.sh.in |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in
> index 1b2f042..e10c345 100644
> --- a/scripts/makepkg.sh.in
> +++ b/scripts/makepkg.sh.in
> @@ -834,9 +834,9 @@ tidy_install() {
>  		find ${STRIP_DIRS[@]} -type f 2>/dev/null | while read binary ; do
>  			case "$(file -biz "$binary")" in
>  				*application/x-sharedlib*)  # Libraries (.so)
> -					/usr/bin/strip --strip-debug "$binary";;
> +					/usr/bin/strip -S "$binary";;
>  				*application/x-archive*)    # Libraries (.a)
> -					/usr/bin/strip --strip-debug "$binary";;
> +					/usr/bin/strip -S "$binary";;
>  				*application/x-executable*) # Binaries
>  					/usr/bin/strip "$binary";;
>  			esac
>   


This seems fine to me.

Allan