[pacman-dev] Fwd: [PATCH] repo-add: fix eval and quote issues

[Aaron Griffin]

On Mon, Feb 9, 2009 at 1:45 PM, Xavier <shiningxc at gmail.com> wrote:
> On Mon, Feb 9, 2009 at 8:28 PM, Aaron Griffin <aaronmgriffin at gmail.com> wrote:
>>
>> The reason I used eval originally was to catch the
>> pkgver=${_somever/-/_} type stuff. Does using declare still work that
>> way?
>>
>
> Afaik, makepkg sources the PKGBUILD already and creates the .PKGINFO
> file based on that, so all variables have already been evaluated. I
> don't see any reason to do it again when repo-add reads the PKGINFO
> file.

Oh oh, I was thinking something else... pardon me. I guess I didn't
realize that we're parsing .PKGINFO files here