[pacman-dev] Fwd: [PATCH] repo-add: fix eval and quote issues

[Kevin Barry]

Sorry I'm coming into the conversation late (Just joined the
listserv). I believe this is about where repo-add does the bsdtar then
grep/sed then evals each line. If someone is about to make a change
there, could the sed also be changed? Mac OS X's sed doesn't work with
\s, so it should be replaced with this:

    for line in $(bsdtar -xOf "$pkgfile" .PKGINFO | \
-       grep -v "^#" | sed 's|\(\w*\)\s*=\s*\(.*\)|\1="\2"|'); do
+        grep -v "^#" | sed 's|\(\w*\)[ \t]*=[ \t]*\(.*\)|\1="\2"|'); do
        eval "$line"

I have some other patches too that I'll be submitting after I get git
setup, so if this is skipped now that's fine.


On Mon, Feb 9, 2009 at 5:19 PM, Aaron Griffin <aaronmgriffin at gmail.com> wrote:
> On Mon, Feb 9, 2009 at 1:45 PM, Xavier <shiningxc at gmail.com> wrote:
>> On Mon, Feb 9, 2009 at 8:28 PM, Aaron Griffin <aaronmgriffin at gmail.com> wrote:
>>>
>>> The reason I used eval originally was to catch the
>>> pkgver=${_somever/-/_} type stuff. Does using declare still work that
>>> way?
>>>
>>
>> Afaik, makepkg sources the PKGBUILD already and creates the .PKGINFO
>> file based on that, so all variables have already been evaluated. I
>> don't see any reason to do it again when repo-add reads the PKGINFO
>> file.
>
> Oh oh, I was thinking something else... pardon me. I guess I didn't
> realize that we're parsing .PKGINFO files here
> _______________________________________________
> pacman-dev mailing list
> pacman-dev at archlinux.org
> http://www.archlinux.org/mailman/listinfo/pacman-dev
>