[pacman-dev] [PATCH] makepkg: tidy version package tests

Allan McRae allan at archlinux.org
Thu Jan 1 23:44:49 EST 2009

Dan McGee wrote:
> On Thu, Jan 1, 2009 at 10:37 PM, Allan McRae <allan at archlinux.org> wrote:
>> The use if "! -z" to check if a string is not null is not good practice
>> so replace with the "-n" option. Also use the AND comparison within one
>> test rather than on two separate tests.
>> Signed-off-by: Allan McRae <allan at archlinux.org>
> Looks good to me, maint- worthy?

I'm not worried on this one really.  It is not an actual problem, just a 
potential one so up to you.

> I really need to jump on making this darnded release, don't I..

We really need to get a fix for that whole umask issue first (now we 
have figured out the cause).


More information about the pacman-dev mailing list