[pacman-dev] [PATCH] Fix bug 9395 by allowing pacman to remove unresolvable packages from a transaction
Xavier
shiningxc at gmail.com
Tue Jan 13 13:08:43 EST 2009
On Tue, Jan 13, 2009 at 11:07 AM, Bryan Ischo
<bji-keyword-pacman.3644cb at www.ischo.com> wrote:
> I'm ready to send my patches as 2 patches:
>
> - One with everything except the removal of the "would you like to not
> ignore this package that you put in your IgnorePkg/IgnoreGroup list" dialog
> - One to subsequently remove said dialog
>
Short and simple patches are much more likely to be accepted :)
So I would do the short and simple patches first, and then basing the
more complex ones on them.
That way, you have more chances that at least a part of your work get merged.
I have to be honest and admit I didn't find the motivation to review
your changes. I do like the idea, but it's still a huge code addition
( lib/libalpm/deps.c | 259
+++++++++++++++++++++++++++++++++++------)
and I was hoping there would be a better and simpler way to integrate
this in the existing code.
Maybe the idea Nagy made several times before, to compute our
dependency graph once and then store it and re-use it, would help
here. But this is a huge change too :)
More information about the pacman-dev
mailing list