[pacman-dev] [PATCH] Fix bug 9395 by allowing pacman to remove unresolvable packages from a transaction
bji-keyword-pacman.3644cb at www.ischo.com
Tue Jan 13 15:07:30 EST 2009
> On Tue, Jan 13, 2009 at 11:07 AM, Bryan Ischo
> <bji-keyword-pacman.3644cb at www.ischo.com> wrote:
>> I'm ready to send my patches as 2 patches:
>> - One with everything except the removal of the "would you like to not
>> ignore this package that you put in your IgnorePkg/IgnoreGroup list" dialog
>> - One to subsequently remove said dialog
> Short and simple patches are much more likely to be accepted :)
> So I would do the short and simple patches first, and then basing the
> more complex ones on them.
> That way, you have more chances that at least a part of your work get merged.
> I have to be honest and admit I didn't find the motivation to review
> your changes. I do like the idea, but it's still a huge code addition
> ( lib/libalpm/deps.c | 259
> and I was hoping there would be a better and simpler way to integrate
> this in the existing code.
> Maybe the idea Nagy made several times before, to compute our
> dependency graph once and then store it and re-use it, would help
> here. But this is a huge change too :)
OK, I'll do my best to split my patches up. But most of what I am
trying to do cannot be split up. If the number of added lines in deps.c
scares you, please understand that it's just the addition of one new
internal data structure, a few helper methods, and some moderate
re-arrangement of one existing function. If you'd apply the patch
locally, you'd be able to see how reasonably self-contained it all is.
Anyway, I'll make one more attempt and getting the patches into a form
that you'll accept.
More information about the pacman-dev