[pacman-dev] New Patches
allan at archlinux.org
Wed Jan 14 07:02:52 EST 2009
Bryan Ischo wrote:
> Hey all. I've broken my change into 5 patches, which have already
> been sent to the list.
> The big one is patch #2, which adds the new ignore logic to deps.c.
> Although the number of lines edited is large, it's just the addition
> of a new data structure, some helper methods, and a rework of
> _alpm_resolvedeps(). There is no way to reduce the size of this patch.
> I hope that these patches are satisfactory. If you'd just give them a
> try they should merge nicely into your tree. Create a branch and
> merge them in and test them out. That's what git is good at right?!?
> Please note that these patches replace all previous patches I've sent
> to this list.
The main patch (#2) is too complex for me to review, but on accepting
that as is, the other patches look quite reasonable. I will give them a
proper spin when I do a testing build later.
I just wanted to point out that you should not to get too discouraged
about the number of resubmits required for your patches. Everybody who
submits patches here goes through the same thing, especially with their
first patch and yours are quite ambitious. You should see the changes
required any time I touch the pacman code...
Keep up the good work,
More information about the pacman-dev